Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Robot Framework recorder code #1172

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

eglitise
Copy link
Collaborator

@eglitise eglitise commented Nov 3, 2023

This PR updates the recorder-generated code for the Robot Framework Appium client. Not sure how well maintained the client is, but the recorder for it should at least be usable now.

  • Fix valid locator strategies
  • Fix conversion to Robot variable values (wrap numbers and booleans in ${})
  • For element actions, first save the locator as a variable (matches the approach of other frameworks)
  • Reorder and group driver command implementations
  • Implement missing driver commands

@eglitise eglitise added enhancement New feature or request fix This resolves a user-facing problem labels Nov 3, 2023
@eglitise eglitise merged commit bc586c4 into appium:main Nov 6, 2023
4 of 5 checks passed
@eglitise eglitise deleted the update-robot-recorder-code branch November 6, 2023 09:12
shiva-guntoju pushed a commit to shiva-guntoju/appium-inspector that referenced this pull request Feb 2, 2024
* feat: update Robot Framework recorder code

* chore: simplify setOrientation for Robot

* chore: fix unnecessary escapes

* fix: change some deprecated methods to extensions
laib3 pushed a commit to laib3/appium-inspector that referenced this pull request Nov 16, 2024
* feat: update Robot Framework recorder code

* chore: simplify setOrientation for Robot

* chore: fix unnecessary escapes

* fix: change some deprecated methods to extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix This resolves a user-facing problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants