wireless devices autoconnection #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added daemon for wireless device autoconnection
| do | ||
| array_device=$(echo ${array[$i]} | tr -d " ") | ||
| #string contains check | ||
| if [[ ${connected_devices} != *${array_device}* ]]; then |
There was a problem hiding this comment.
wouldn't it be more appropriate to user grep for this purpose?
Contributor
Author
There was a problem hiding this comment.
basically it is the same thing
| #string contains check | ||
| if [[ ${connected_devices} != *${array_device}* ]]; then | ||
| echo "Connecting to: ${array_device}" | ||
| adb connect ${array_device} |
There was a problem hiding this comment.
should we check the exit code here to make sure the connection was really successful?
Contributor
Author
There was a problem hiding this comment.
No, we don't care. Anyway script will be run again after specified delay.
It is the main idea of this PR. Script will try to reconnect to remote device in any case
Contributor
Author
|
Unfortunately this PR is not finished |
Member
|
Awesome @red-avtovo 👍 |
Contributor
Author
|
Now it's done! |
Updated entry point and Dockerfile
red-avtovo
force-pushed
the
wireless_devices_autoconnect
branch
from
e00d07e to
5360b90
Compare
SrinivasanTarget
approved these changes
Oct 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added daemon for wireless device autoconnection