update required an optional parameters for getting performance

[KazuCocoa]

To get performance data via appium/java-client#562 , this driver should apply parameters packageName, dataType and dataReadTimeout , not applicationPackageName and performanceDataType, I think.

The following log is sending parameters with packageName, dataType and dataReadTimeout. If I sent parameters with applicationPackageName and performanceDataType, then Appium return {} as the result.

What do you think? @heeseon

[HTTP] --> POST /wd/hub/session/b3250db7-4d90-4e52-b0bb-989940cb08ae/appium/getPerformanceData {"packageName":"io.appium.android.apis","dataType":"cpuinfo","dataReadTimeout":1000}
[debug] [MJSONWP] Calling AppiumDriver.getPerformanceData() with args: ["io.appium.android.apis","cpuinfo",1000,null,null,"b3250db7-4d90-4e52-b0bb-989940cb08ae"]
[debug] [ADB] Getting connected devices...
[debug] [ADB] 1 device(s) connected
[debug] [ADB] Running 'adb' with args: ["-P",5037,"shell","dumpsys","cpuinfo","|","grep","'io.appium.android.apis'"]
[debug] [MJSONWP] Responding to client with driver.getPerformanceData() result: [["user","kernel"],["0","0"]]
[HTTP] <-- POST /wd/hub/session/b3250db7-4d90-4e52-b0bb-989940cb08ae/appium/getPerformanceData 200 140 ms - 101 
[HTTP] --> POST /wd/hub/session/b3250db7-4d90-4e52-b0bb-989940cb08ae/appium/getPerformanceData {"packageName":"io.appium.android.apis","dataType":"cpuinfo","dataReadTimeout":1000}
[debug] [MJSONWP] Calling AppiumDriver.getPerformanceData() with args: ["io.appium.android.apis","cpuinfo",1000,null,null,"b3250db7-4d90-4e52-b0bb-989940cb08ae"]
[debug] [ADB] Getting connected devices...
[debug] [ADB] 1 device(s) connected
[debug] [ADB] Running 'adb' with args: ["-P",5037,"shell","dumpsys","cpuinfo","|","grep","'io.appium.android.apis'"]
[debug] [MJSONWP] Responding to client with driver.getPerformanceData() result: [["user","kernel"],["0","0"]]
[HTTP] <-- POST /wd/hub/session/b3250db7-4d90-4e52-b0bb-989940cb08ae/appium/getPerformanceData 200 173 ms - 101 
[HTTP] --> POST /wd/hub/session/b3250db7-4d90-4e52-b0bb-989940cb08ae/appium/getPerformanceData {"packageName":"io.appium.android.apis","dataType":"batteryinfo","dataReadTimeout":1000}
[debug] [MJSONWP] Calling AppiumDriver.getPerformanceData() with args: ["io.appium.android.apis","batteryinfo",1000,null,null,"b3250db7-4d90-4e52-b0bb-989940cb08ae"]
[debug] [ADB] Getting connected devices...
[debug] [ADB] 1 device(s) connected
[debug] [ADB] Running 'adb' with args: ["-P",5037,"shell","dumpsys","battery","|","grep","'level'"]
[debug] [MJSONWP] Responding to client with driver.getPerformanceData() result: [["power"],["64"]]
[HTTP] <-- POST /wd/hub/session/b3250db7-4d90-4e52-b0bb-989940cb08ae/appium/getPerformanceData 200 106 ms - 90 
[HTTP] --> POST /wd/hub/session/b3250db7-4d90-4e52-b0bb-989940cb08ae/appium/getPerformanceData {"packageName":"io.appium.android.apis","dataType":"memoryinfo","dataReadTimeout":1000}
[debug] [MJSONWP] Calling AppiumDriver.getPerformanceData() with args: ["io.appium.android.apis","memoryinfo",1000,null,null,"b3250db7-4d90-4e52-b0bb-989940cb08ae"]
[debug] [ADB] Getting connected devices...
[debug] [ADB] 1 device(s) connected
[debug] [ADB] Running 'adb' with args: ["-P",5037,"shell","dumpsys","meminfo","'io.appium.android.apis'","|","grep","-E","'Native|Dalvik|EGL|GL|TOTAL'"]
[debug] [MJSONWP] Responding to client with driver.getPerformanceData() result: [["totalPrivateDirty","nativePrivateDirty","dalvikPrivateDirty","eglPrivateDirty","glPrivateDirty","totalPss","nativePss","dalvikPss","eglPss","glPss","nativeHeapAllocatedSize","nativeHeapSize"],["35564","3100","2632","27360",null,"37609","3107","2666","27360",null,"7168","1742"]]
[HTTP] <-- POST /wd/hub/session/b3250db7-4d90-4e52-b0bb-989940cb08ae/appium/getPerformanceData 200 392 ms - 353 

---

I also try to implement in ruby_lib

[imurchie]

I'm for this. The unit test for protocol consistency needs to be updated though. https://github.com/appium/appium-base-driver/blob/master/test/mjsonwp/routes-specs.js#L41

[KazuCocoa]

I updated the hash in 2484263

[jlipps]

Thanks @KazuCocoa!

[jlipps]

@imurchie technically this is a breaking change to the protocol. do you know of any other clients that would stop working because of this change? wanting to know what semver update to publish as.

[imurchie]

@jlipps I'm not aware of any other clients actually implementing this.

[KazuCocoa]

I also not sure any clients implementing this. Java client and ruby client are just trying to implement this feature. In addition, each client will work fine with this PR, not current API.

…

On Thu, Feb 2, 29 Heisei at 10:00 PM, Isaac A. Murchie < ***@***.***> wrote: @jlipps <https://github.com/jlipps> I'm not aware of any other clients actually implementing this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#103 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFQZpzWK2PkNFyn0rUucr0bs_O9OvS6mks5rYdNggaJpZM4LzUrv> .

[jlipps]

Well let's merge it then as soon as @imurchie approves!

[imurchie]

Approved!

[jlipps]

great, published as appium-base-driver@2.1.7