-
Notifications
You must be signed in to change notification settings - Fork 66
Merging new navbar and tooltips into master #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- Added new web pack config for navbar components, to publish it as library -- Fixed issues with NavBar and SearchBar
-- Trying with travis.yml
-- Parse error fixes
-- Fixed module name
-- Changed bucket name
Feature/bundle navbar component
-- Cleanup of web pack config
-- Updated CDN prefix.
-- Carousel component created -- It behaves same on both mobile and desktop -- Swipe is not yet supported for mobile devices
-- Fixing lint errors
-- Added component for SubNav using the Carousel component.
-- Fixed lint errors
-- Fixed padding
-- Implemented code review suggestions
-- Removed unused dependencies
-- Added encrypted aws key and secret
Feature/bundle navbar component
-- Excluded ReactDOM and moment from build
AS#102481437698830, Travis build to push bundle to S3/CDN
-- Updated build flags
AS#102481437698830, Travis build to push bundle to S3/CDN
-- Added username property
…gin state using username -- Used username property to determine the state of login
-- Added support for rendering StandardListItem as hyperlink
…h real URLs -- Used hyperlinks -- Used StandardListItem's icon to show icons instead of using separate div -- Added real URLs with dynamic domain
…h real URLs -- Passed domain to QuickLinks component from NavBar component
Feature/misc fixes
* dev: AS#104536643797659, Update QuickLinks component to use hyperlinks with real URLs AS#104536643797659, Update QuickLinks component to use hyperlinks with real URLs AS#103506492417792, Support hyperlinks in StandardListItem component Fixed lint errors AS#103506492417790, Adjust UserDropdownMenu component to determine login state using username AS#103506492417787, Add username as property for NavBar NavBar miscellaneous fixes/improvements AS#102481437698830, Travis build to push bundle to S3/CDN AS#102481437698830, Travis build to push bundle to S3/CDN AS#102481437698830, Travis build to push bundle to S3/CDN AS#101967871059519, Bundle NavBar components to be used by tc-site AS#101967871059519, Bundle NavBar components to be used by tc-site AS#101967871059519, Bundle NavBar components to be used by tc-site Conflicts: package.json
…term in search bar
…term in search bar -- Fixed lint errors
* master: Tooltip final fix - moved target element inside Tooltip component Final Fixes final fix - theme styles moved to example scss file Fix syntax Add comma space rule
* master: Using TaggedValueList component Added config to hide circles final fixes Final Fixes - Progress Bar Component
…term in search bar -- Added pointer mouse cursor to the search icon
…earchBar component -- Changed suggestions array input to the SearchBar component as functional callback instead of properties. This would prevent error scenarios where multiple requests in the parent component are updating the same object for better memory usage. -- Added logic for handling multiple requests and selecting only the latest request's response to update the SearchBar component.
…earchBar component -- Fixed lint errors
-- Handled error in search suggestion function.
-- Fixed lint errors
-- Added desired behaviour
-- Handled case where there was no search suggestion
…sted terms in SearchBar -- Added up down arrow key behaviour. Need to do some more testing and cleanup
…sted terms in SearchBar -- Fixed lint errors
Solution for avoiding css conflicts especially with name of container.
…tocomplete Feature/forward arrow key autocomplete
-- Added support for regex -- Added support for reading selected state via property
-- Fixed lint errors
-- Implemented code review suggestion
AS#113534202832111, SearchBar - Do not search with empty search term -- Done
…earchBar -- Fixing lint errors
…earchBar -- Fixing lint errors
…earchBar -- Removed type attribute for time being because it is causing style issues with typeahead text and clear icon (rendered by browser) is not working for firefox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.