Skip to content

Merging new navbar and tooltips into master #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 113 commits into from
May 5, 2016
Merged

Merging new navbar and tooltips into master #83

merged 113 commits into from
May 5, 2016

Conversation

nlitwin
Copy link
Contributor

@nlitwin nlitwin commented May 5, 2016

No description provided.

vikasrohit added 30 commits March 18, 2016 15:03
-- Added new web pack config for navbar components, to publish it as library
-- Fixed issues with NavBar and SearchBar
-- Carousel component created
-- It behaves same on both mobile and desktop
-- Swipe is not yet supported for mobile devices
-- Added component for SubNav using the Carousel component.
-- Implemented code review suggestions
-- Added encrypted aws key and secret
-- Excluded ReactDOM and moment from build
AS#102481437698830, Travis build to push bundle to S3/CDN
AS#102481437698830, Travis build to push bundle to S3/CDN
…gin state using username

-- Used username property to determine the state of login
-- Added support for rendering StandardListItem as hyperlink
…h real URLs

-- Used hyperlinks
-- Used StandardListItem's icon to show icons instead of using separate div
-- Added real URLs with dynamic domain
…h real URLs

-- Passed domain to QuickLinks component from NavBar component
* dev:
  AS#104536643797659, Update QuickLinks component to use hyperlinks with real URLs
  AS#104536643797659, Update QuickLinks component to use hyperlinks with real URLs
  AS#103506492417792, Support hyperlinks in StandardListItem component
  Fixed lint errors
  AS#103506492417790, Adjust UserDropdownMenu component to determine login state using username
  AS#103506492417787, Add username as property for NavBar
  NavBar miscellaneous fixes/improvements
  AS#102481437698830, Travis build to push bundle to S3/CDN
  AS#102481437698830, Travis build to push bundle to S3/CDN
  AS#102481437698830, Travis build to push bundle to S3/CDN
  AS#101967871059519, Bundle NavBar components to be used by tc-site
  AS#101967871059519, Bundle NavBar components to be used by tc-site
  AS#101967871059519, Bundle NavBar components to be used by tc-site

Conflicts:
	package.json
vikasrohit added 28 commits April 7, 2016 15:34
* master:
  Tooltip final fix - moved target element inside Tooltip component
  Final Fixes
  final fix - theme styles moved to example scss file
  Fix syntax
  Add comma space rule
* master:
  Using TaggedValueList component
  Added config to hide circles
  final fixes
  Final Fixes - Progress Bar Component
…term in search bar

-- Added pointer mouse cursor to the search icon
…earchBar component

-- Changed suggestions array input to the SearchBar component as functional callback instead of properties. This would prevent error scenarios where multiple requests in the parent component are updating the same object for better memory usage.
-- Added logic for handling multiple requests and selecting only the latest request's response to update the SearchBar  component.
-- Handled error in search suggestion function.
-- Handled case where there was no search suggestion
…sted terms in SearchBar

-- Added up down arrow key behaviour. Need to do some more testing and cleanup
…sted terms in SearchBar

-- Fixed lint errors
Solution for avoiding css conflicts especially with name of container.
…tocomplete

Feature/forward arrow key autocomplete
-- Added support for regex
-- Added support for reading selected state via property
AS#113534202832111, SearchBar - Do not search with empty search term

-- Done
…earchBar

-- Removed type attribute for time being because it is causing style issues with typeahead text and clear icon (rendered by browser) is not working for firefox.
@nlitwin nlitwin merged commit 0a27a49 into master May 5, 2016
@nlitwin nlitwin deleted the dev branch May 5, 2016 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants