Skip to content

create story showing bug with using uncontrolled inputs in HMF … #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tyleralves wants to merge 1 commit into from
Closed

create story showing bug with using uncontrolled inputs in HMF … #750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion stories/HasManyFields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ import {
HasManyFields,
HasManyFieldsAdd,
HasManyFieldsRow,
Input
Input,
Select
} from '../src';
import COUNTRIES from '../src/components/address/Countries';

const items = [
{
Expand Down Expand Up @@ -37,7 +39,23 @@ const items = [
},
];

const UncontrolledSelect = () => <Select options={COUNTRIES} />;

storiesOf('HasManyFields', module)
.add('Uncontrolled inputs', () => (
<HasManyFields
template={UncontrolledSelect}
label="Add a state"
disabled={boolean('disabled', false)}
onAdd={action('hasManyFields onAdd')}
onRemove={action('hasManyFields onRemove')}
onUpdate={action('hasManyFields onUpdate')}
onChange={action('hasManyFields onChange')}
minimumRows={number('minimumRows', 1)}
maximumRows={number('maximumRows', 5)}
reorderable={boolean('reorderable', false)}
/>
))
Copy link
Contributor

@gthomas-appfolio gthomas-appfolio Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something you want to merge, or just bug demo?

Copy link
Contributor Author

@tyleralves tyleralves Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bug demo that I'll attach to an issue. I would also add this commit to a fix on a future FFF.

.add('Live Example', () => (
<HasManyFields
defaultValue={items}
Expand Down