ADFA-2723: Fix the debugger tooltip behaviour

[dara-abijo-adfa]

• Display the tooltip below the debugger toolbar so the toolbar is always visible
• Don't show tooltip when toolbar is being dragged

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR enhances tooltip rendering for debug overlay windows and refines touch event handling in the debug overlay. It adds overlay window detection to tooltips with centered on-screen display and dynamic icon tinting, while improving drag vs. click distinction in the overlay manager through refined touch threshold logic.

Changes

Cohort / File(s)	Summary
Debug Overlay Touch Handling app/src/main/java/com/itsaky/androidide/services/debug/DebugOverlayManager.kt	Improved touch event handling with refined dragging threshold using absolute delta values, explicit drag state initialization on ACTION_DOWN, split behavior for ACTION_UP distinguishing drag vs. click, and new ACTION_CANCEL case to reset state. Moved long-click tooltip anchor from current view to rootView.
Debug Actions Overlay Tooltip Anchor app/src/main/java/com/itsaky/androidide/services/debug/DebuggerActionsOverlayAdapter.kt	Changed tooltip anchor target from current view to rootView in long-click handler.
Tooltip Overlay Window Support idetooltips/src/main/java/com/itsaky/androidide/idetooltips/ToolTipManager.kt	Added overlay window detection and conditional tooltip display path; tooltips in overlay windows are now centered on-screen. Introduced dynamic icon tinting (white in overlays, theme-based otherwise) and refactored button click handlers to use apply blocks. Added helper methods: View.isInOverlayWindow() and showOverlayTooltip().

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• ADFA-1383 - debugger toolbar tooltips #854: Modifies same tooltip code paths with long-click behavior and overlay enhancements in DebugOverlayManager and TooltipManager.
• fix(ADFA-2579): Make font slider responsive #862: Updates long-press tooltip handling and anchoring/presentation in debug overlays using TooltipManager methods.
• fix(ADFA-2461): Show tooltips in navigation rails #772: Enhances tooltip display behavior in ToolTipManager with overlay-specific logic.

Suggested reviewers

• itsaky-adfa
• Daniel-ADFA
• jomen-adfa

Poem

🐰 Tooltips floating in the overlay sky,
Anchored roots keep them way up high,
White-tinted icons catch the light,
Touch thresholds dance through wrong and right,
Drag or click—now the overlays know! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is directly related to the changeset, clearly stating the two key objectives: displaying tooltips below the toolbar and preventing display during dragging.
Title check	✅ Passed	The title 'Fix the debugger tooltip behaviour' accurately reflects the main changes: adjusting tooltip positioning, preventing tooltip display during dragging, and icon tinting.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ADFA-2723-fix-debugger-tooltip-drag

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@idetooltips/src/main/java/com/itsaky/androidide/idetooltips/ToolTipManager.kt`:
- Around line 488-509: showOverlayTooltip measures popupView before the WebView
content is rendered, so measuredWidth/measuredHeight are from the empty state
and center (x,y) is wrong; fix by deferring the centering until content/layout
is stable: register a WebViewClient.onPageFinished (for
WebView.loadDataWithBaseURL) or a ViewTreeObserver.OnGlobalLayoutListener on
popupView (or the WebView inside it), then recompute popupView.measure(),
popupView.measuredWidth/height and call popupWindow.update(...) or reposition
via popupWindow.showAtLocation(parentView, Gravity.NO_GRAVITY, x, y) again to
recenter once the WebView has finished loading/rendering.

🧹 Nitpick comments (1)

idetooltips/src/main/java/com/itsaky/androidide/idetooltips/ToolTipManager.kt (1)

482-486: isInOverlayWindow() only works reliably on the root view added to WindowManager.

view.layoutParams returns the params assigned by the view's immediate parent. For any child view in the hierarchy, this would be a ViewGroup.LayoutParams subclass (e.g., LinearLayout.LayoutParams), not WindowManager.LayoutParams — so the check would silently return false. It works today because callers pass rootView, but a future caller passing a non-root view would get incorrect results.

Consider either:

• Renaming to make the contract explicit (e.g., isOverlayRootView()), or
• Walking up to the actual root: rootView.layoutParams.

Suggested hardening

-    private fun View.isInOverlayWindow(): Boolean {
-        val params = layoutParams
+    private fun View.isInOverlayWindow(): Boolean {
+        val params = rootView.layoutParams
         return params is WindowManager.LayoutParams &&
                 params.type == WindowManager.LayoutParams.TYPE_APPLICATION_OVERLAY
     }