Skip to content

ADFA-2827 Relocate plugin 3rd party disclaimer to strings.xml #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hal-eisen-adfa merged 4 commits into from
Feb 11, 2026
Merged

ADFA-2827 Relocate plugin 3rd party disclaimer to strings.xml #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5f4924
Relocate plugin 3rd part disclaimer to strings.xml
hal-eisen-adfa Feb 6, 2026
539a3db
Simplify to only create 'val disclaimer' once not twice
hal-eisen-adfa Feb 11, 2026
1762e84
Merge branch 'stage' into ADFA-2827-Externalize-disclaimer-string
hal-eisen-adfa Feb 11, 2026
2f5016b
Merge branch 'stage' into ADFA-2827-Externalize-disclaimer-string
hal-eisen-adfa Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .../kotlin/com/itsaky/androidide/plugins/manager/documentation/PluginDocumentationManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import android.database.sqlite.SQLiteDatabase
import android.util.Log
import com.itsaky.androidide.plugins.extensions.DocumentationExtension
import com.itsaky.androidide.plugins.extensions.PluginTooltipEntry
import com.itsaky.androidide.resources.R
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
import java.io.File
Expand All @@ -24,7 +25,6 @@ class PluginDocumentationManager(private val context: Context) {

private val databaseVersion = 1
private val databaseName = "plugin_documentation.db"
private val thirdPartyDisclaimer = "<br><br><em style='color: #888; font-size: 0.9em;'>⚠️ This documentation is provided by a third-party plugin.</em>"

// Database schema creation statements
private val createCategoriesTable = """
Expand Down Expand Up @@ -326,6 +326,7 @@ class PluginDocumentationManager(private val context: Context) {
categoryId: Long,
entry: PluginTooltipEntry
): Long {
val disclaimer = context.getString(R.string.plugin_documentation_third_party_disclaimer)
// Check if tooltip with same tag already exists in this category
val existingCursor = db.query(
"PluginTooltips",
Expand All @@ -341,8 +342,8 @@ class PluginDocumentationManager(private val context: Context) {

// Update existing tooltip with disclaimer
val updateValues = ContentValues().apply {
put("summary", entry.summary + thirdPartyDisclaimer)
put("detail", if (entry.detail.isNotBlank()) entry.detail + thirdPartyDisclaimer else "")
put("summary", entry.summary + disclaimer)
put("detail", if (entry.detail.isNotBlank()) entry.detail + disclaimer else "")
}
db.update("PluginTooltips", updateValues, "id = ?", arrayOf(existingId.toString()))

Expand All @@ -357,8 +358,8 @@ class PluginDocumentationManager(private val context: Context) {
val values = ContentValues().apply {
put("categoryId", categoryId)
put("tag", entry.tag)
put("summary", entry.summary + thirdPartyDisclaimer)
put("detail", if (entry.detail.isNotBlank()) entry.detail + thirdPartyDisclaimer else "")
put("summary", entry.summary + disclaimer)
put("detail", if (entry.detail.isNotBlank()) entry.detail + disclaimer else "")
}
return db.insert("PluginTooltips", null, values)
}
Expand Down
1 change: 1 addition & 0 deletions resources/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,7 @@
<!-- Tooltip HTML Components -->
<string name="tooltip_buttons_separator"><![CDATA[<br>]]></string>
<string name="tooltip_detail_links_template"><![CDATA[%1$s<br><br>%2$s]]></string>
<string name="plugin_documentation_third_party_disclaimer">&lt;br&gt;&lt;br&gt;&lt;em style=&quot;color: #888; font-size: 0.9em;&quot;&gt;This documentation is provided by a third-party plugin.&lt;/em&gt;</string>

<!-- Tooltip Debug Dialog -->
<string name="tooltip_debug_dialog_title">Tooltip Debug Info</string>
Expand Down