Skip to content

ADFA-2779: update to NDK r29#917

Merged
itsaky-adfa merged 2 commits intostagefrom
fix/ADFA-2779
Feb 9, 2026
Merged

ADFA-2779: update to NDK r29#917
itsaky-adfa merged 2 commits intostagefrom
fix/ADFA-2779

Conversation

@itsaky-adfa
Copy link
Contributor

@itsaky-adfa itsaky-adfa commented Feb 3, 2026

See ADFA-2779 for more details.

Signed-off-by: Akash Yadav <akashyadav@appdevforall.org>
@itsaky-adfa itsaky-adfa requested a review from a team February 3, 2026 09:30
@itsaky-adfa itsaky-adfa self-assigned this Feb 3, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Release Notes

  • Updated Android NDK to r29: NDK version updated from r28.1.13356709 to r29.0.14206865

Risks & Important Notes:

  • ⚠️ Major version upgrade: This is a significant jump from NDK r28 to r29 that may introduce breaking changes in the native C/C++ toolchain
  • ⚠️ Comprehensive testing required: All native code compilation and execution paths should be thoroughly tested due to potential compiler behavior differences between major versions
  • ⚠️ Potential compatibility issues: Ensure all native libraries and dependencies compiled with the new NDK are compatible with the target Android APIs and the rest of the application
  • ⚠️ Build environment synchronization: Ensure all developers and CI/CD pipelines update their NDK installations to r29 to avoid inconsistent builds
  • ℹ️ Single-file change: Only the BuildConfig constant was updated; verify that all build files and dependencies that reference NDK version are correctly synchronized

Walkthrough

Updates the NDK version constant in BuildConfig from version 28.1.13356709 to 29.0.14206865. This is a straightforward constant value change with no logic modifications.

Changes

Cohort / File(s) Summary
NDK Version Update
composite-builds/build-logic/common/src/main/java/com/itsaky/androidide/build/config/BuildConfig.kt
Updated NDK_VERSION constant from "28.1.13356709" to "29.0.14206865".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • dara-abijo-adfa
  • jatezzz

Poem

🐰 Hopping with glee, version's been bumped,
NDK twenty-nine, development's jumped,
From twenty-eight's nest to newer ground,
A tiny update, so perfectly sound!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating the NDK version from 28 to 29, which matches the constant update in BuildConfig.
Description check ✅ Passed The description references the related issue ADFA-2779 with a direct link, which is relevant to understanding the context of this NDK version update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ADFA-2779

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@itsaky-adfa itsaky-adfa merged commit 5115fa5 into stage Feb 9, 2026
2 checks passed
@itsaky-adfa itsaky-adfa deleted the fix/ADFA-2779 branch February 9, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments