Skip to content

ADFA-1990: Add main screen missing tooltips#889

Merged
dara-abijo-adfa merged 5 commits intostagefrom
ADFA-1990-main-screen-missing-tooltips
Jan 30, 2026
Merged

ADFA-1990: Add main screen missing tooltips#889
dara-abijo-adfa merged 5 commits intostagefrom
ADFA-1990-main-screen-missing-tooltips

Conversation

@dara-abijo-adfa
Copy link
Contributor

Add tooltips to Preferences and Terminal actions on the main screen

@dara-abijo-adfa dara-abijo-adfa self-assigned this Jan 27, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Release Notes

Features Added

  • Added missing tooltips to main screen actions:
    • "Preferences" action now displays tooltip with tag MAIN_PREFERENCES
    • "Terminal" action now displays tooltip with tag MAIN_TERMINAL

Changes

  • New tooltip tag constants added to TooltipTag.kt:
    • MAIN_PREFERENCES = "main.prefs"
    • MAIN_TERMINAL = "main.terminal"
  • Updated MainFragment.kt tooltip resolution to map actions to their respective tooltip tags
  • Restored terminal and preferences action handlers in main action handling

⚠️ Risks and Considerations

  • Behavioral Change: The removal of the previous onLongClick specialization for ACTION_OPEN_TERMINAL (which started TerminalActivity with TERMUX_FAILSAFE session) changes the interaction model. Verify that this removal is intentional and won't impact existing users who relied on this functionality.
  • Incomplete Migration: The raw summary indicates restoration of action handlers, suggesting there may have been previous changes. Ensure these restored handlers have been properly tested and match the original intended behavior.

Walkthrough

This pull request adds two new tooltip tag constants (MAIN_PREFERENCES and MAIN_TERMINAL) and integrates them into the main fragment's action handling system. It restores the onClick actions for opening the terminal and navigating to preferences, while mapping these actions to their corresponding tooltip tags for UI enhancement.

Changes

Cohort / File(s) Summary
Tooltip Tag Constants
idetooltips/src/main/java/com/itsaky/androidide/idetooltips/TooltipTag.kt
Added two new public constants: MAIN_PREFERENCES ("main.prefs") and MAIN_TERMINAL ("main.terminal") to expose tooltip identifiers.
Main Fragment Action Integration
app/src/main/java/com/itsaky/androidide/fragments/MainFragment.kt
Added tooltip tag imports and extended action mapping logic to handle ACTION_OPEN_TERMINAL and ACTION_PREFERENCES with corresponding tooltip tag resolution and action invocations. Removed legacy onLongClick specialization for terminal action.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Daniel-ADFA
  • jomen-adfa
  • itsaky-adfa

Poem

🐰 Tooltips bloom like carrots in the sun,
Terminal and preferences, now wired as one,
Tags restored with floppy-eared delight,
Actions mapped in a helpful light,
No mystery now—just clarity, hooray!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding missing tooltips to the main screen, which aligns with the changeset that adds MAIN_PREFERENCES and MAIN_TERMINAL tooltip constants and their integration.
Description check ✅ Passed The description is directly related to the changeset, specifying that tooltips are being added to Preferences and Terminal actions on the main screen.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dara-abijo-adfa dara-abijo-adfa merged commit 291be09 into stage Jan 30, 2026
2 checks passed
@dara-abijo-adfa dara-abijo-adfa deleted the ADFA-1990-main-screen-missing-tooltips branch January 30, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments