loadMoreLabel

[rap2hpoutre]

See: #515 (comment)

The prop is a string to be consistent with missingLabel, filterLabel, etc. It's called *Label for the same reason. Still, I can edit the PR and change behavior.

[metagrover]

Hi @rap2hpoutre, this looks good overall. 👌

One minor issue - this only supports string types. Please refer the title prop usage in this component, where we take both string and JSX inputs. Having JSX inputs will offer more customisability.

We will need to apply the same for SingleList, SingleDropdownList and MultiDropdownList as well

[rap2hpoutre]

@metagrover Thank you for your review. 👍

I'm not sure to understand:

title prop is of type title. Do you want me to change the type of loadMoreLabel to title? (that sounds a bit strange to me, that's why I feel like I misunderstood something :) !).

I checked types here: https://github.com/appbaseio/reactivecore/blob/master/src/utils/types.js and saw that title is:

title: oneOfType([string, any]),

Do you want me to create a new label type in another PR on this other repo before?

I'm a bit lost 😅

[metagrover]

@rap2hpoutre You can use title type with loadMoreLabel.

[rap2hpoutre]

@metagrover Done!

[metagrover]

Awesome 💯

Now, it would be great if you can replicate this on SingleList, SingleDropdownList and MultiDropdownList.

[rap2hpoutre]

@metagrover Done! 🎉

[divyanshu013]

Looks good, could you also update the typings files please? Each component has its own .d.ts file. You could use the same typing from title

[rap2hpoutre]

@divyanshu013 @metagrover Done.

[metagrover]

@rap2hpoutre Thanks for contributing 🤝

[davidkong0987]

how are loadMore and handleLoadMore used in ReactiveList? They seem like interesting properties but I couldn't find much on them.