Skip to content

feat(web): support for dom node in ReactiveList's scrollTarget prop #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bietkul merged 1 commit into from
Nov 18, 2019
Merged

feat(web): support for dom node in ReactiveList's scrollTarget prop #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web/src/components/result/ReactiveList.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ declare namespace ReactiveListTree {
onPageClick?: (...args: any[]) => any;
defaultPage?: number;
listClass?: string;
scrollTarget?: string;
scrollTarget?: string | Element | HTMLDocument;
onData?: (...args: any[]) => any;
renderNoResults?: types.title;
scrollOnChange?: boolean;
Expand Down
4 changes: 3 additions & 1 deletion packages/web/src/components/result/ReactiveList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,10 @@ class ReactiveList extends Component {
this.domNode = window;
if (this.showInfiniteScroll) {
const { scrollTarget } = this.props;
if (scrollTarget) {
if (typeof scrollTarget === 'string' || scrollTarget instanceof String) {
this.domNode = document.getElementById(scrollTarget);
} else if (scrollTarget instanceof Element || scrollTarget instanceof HTMLDocument) {
this.domNode = scrollTarget;
}
this.domNode.addEventListener('scroll', this.scrollHandler);
}
Expand Down