Version updates, refs warning issue resolved #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZigZagT
reviewed
Sep 14, 2021
| }; | ||
|
|
||
| render() { | ||
| let { |
There was a problem hiding this comment.
Have you run eslint against these files?
These changes do not look compatible with our prettier settings
Author
There was a problem hiding this comment.
ah yes - I have some trouble getting vscode to correctly inherit repo eslint settings over my default configurations. I'll revert the formatting settings in the next few days
There was a problem hiding this comment.
you can run it with cli
yarn eslint --fix .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing an issue with react 17 where refs were being passed as strings incorrectly. inner refs should fix the issue