[LD-1386] Fix Python scripts and add reveal_phone_number + webhook-url fields #72
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atulm3991
reviewed
May 6, 2024
| @@ -35,23 +37,25 @@ url = "https://api.apollo.io/api/v1/people/bulk_match" | |||
|
|
|||
| data = { | |||
| "api_key": "YOUR API KEY HERE", | |||
| "reveal_personal_emails": true, | |||
| "reveal_personal_emails": True, | |||
There was a problem hiding this comment.
Please keep this as true instead of True. Same way for other places as well
There was a problem hiding this comment.
This is actually wrong. Python boolean representation is True and not true
Therefore, when a request is made from python, we should have True.
Kavya-24
added a commit
that referenced
this pull request
May 14, 2024
generated from commit 334e844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you've checked off all these things before submitting:
https://apollopde.atlassian.net/browse/LD-1386
Core Incident: https://apollopde.atlassian.net/browse/INCIDENT-8522
reveal_phone_numberandwebhook_urlfieldBefore:
After
masterbranch.