Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

[BREAKING CHANGE]: Cleanup for deprecated API #272

Merged
merged 3 commits into from
Sep 14, 2017

Conversation

DxCx
Copy link
Contributor

@DxCx DxCx commented Sep 14, 2017

This PR Removes:

  • General:
    • addGraphQLSubscriptions => use apollo-link-split instead. more info
  • Server:
    • onSubscribe => use onOperation instead.
    • onUnsubscribe => use onOperationComplete instead.
  • Client:
    • onConnect => use onConnecting or onConnected instead.
    • onDisconnect => use onDisconnected instead.
    • onReconnect => use onReconnecting or onReconnected instead.
    • unsubscribe => use Subscription.unsubscribe instead.
    • query => use request instead.
    • subscribe => use request instead.

Also, aligns tests.

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

Related to #261

@DxCx DxCx requested a review from NeoPhi September 14, 2017 09:55
Copy link
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @DxCx 👍

@NeoPhi NeoPhi merged commit aefd199 into apollographql:master Sep 14, 2017
@DxCx DxCx deleted the deprecate-api branch September 14, 2017 17:55
@bderen
Copy link

bderen commented Sep 24, 2017

Guys, how about react-apollo ?
It seems not possible to use apollo-link-split with ApolloClient from react-apollo

addGraphQLSubscriptions => use apollo-link-split instead

any ideas?

@DxCx
Copy link
Contributor Author

DxCx commented Sep 24, 2017

please try and use apollo 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants