helm chart: allow specifying extra containers #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garypen
requested changes
Mar 31, 2023
There was a problem hiding this comment.
Thanks! I think this is a great addition. In addition to my helm-docs suggestion, could you also please fill in a changeset description for your PR.
pcarrier
force-pushed
the
pcarrier/extraContainers
branch
from
d4aa49e
to
38bf290
Compare
o0Ignition0o
approved these changes
Apr 4, 2023
garypen
approved these changes
Apr 4, 2023
Merged
pcarrier
added a commit
to pcarrier/router
that referenced
this pull request
Apr 17, 2023
6 tasks
pcarrier
added a commit
to pcarrier/router
that referenced
this pull request
Apr 17, 2023
pcarrier
added a commit
to pcarrier/router
that referenced
this pull request
Apr 17, 2023
garypen
added a commit
that referenced
this pull request
Apr 18, 2023
The [previous PR](#2881) does not indent correctly and makes it impossible to create extra containers. **Checklist** Complete the checklist (and note appropriate exceptions) before a final PR is raised. - [x] Changes are compatible[^1] - [x] Documentation[^2] completed - [x] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** I nurture a distaste for YAML, text/template, and Helm, merely copied from context, and do not understand the before nor the after. This was tested using `helm package`, copying the resulting tarball in internal Helm charts, then running `helm install … --dry-run --debug`. While I'm not 100% sure it is correct, the generated YAML seemed correct after converting to JSON and back. Co-authored-by: Gary Pennington <gary@apollographql.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sidecars, like coprocessors, in the official helm chart.
Checklist
Complete the checklist (and note appropriate exceptions) before a final PR is raised.
Exceptions
Note any exceptions here
Notes
[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as
manual test