Query planner reloads #2309
Merged
Query planner reloads #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a client timeouts and cancels a request before the query planner has finished, we would still want to put the query plan in the cache, so it is available the next time that query comes in. So we run it in a separate task, and have the current request await on it
This comment has been minimized.
This comment has been minimized.
On schema updates, the query plan cache must be rebuilt from scratch, which causes latency instabilities. This adds a warm up phase, that gets the queries already in cache for the previous schema, and runs them through the query planner with the new schema and caches them, before switching the router to use the new schema. The warmed up queries will use the cache directly and keep the same latency. This can make schema updates slow and CPU intensive though, as we have to wait for all the query plans to be generated.
o0Ignition0o
approved these changes
Dec 22, 2022
Co-authored-by: Jeremy Lempereur <jeremy.lempereur@iomentum.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2302
Fix #2308
if a client timeouts and cancels a request before the query planner has finished, we would still want to put the query plan in the cache, so it is available the next time that query comes in. So we run it in a separate task, and have the current request await on it