Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more details when graphql request is invalid #2306

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Dec 21, 2022

close #2301

here is the new error you'll receive:

{
  "message": "Invalid GraphQL request",
  "extensions": {
    "details": "failed to deserialize the request body into JSON: invalid type: string \"null\", expected a map at line 1 column 100",
    "code": "INVALID_GRAPHQL_REQUEST"
  }
}

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj self-assigned this Dec 21, 2022
@github-actions

This comment has been minimized.

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
NEXT_CHANGELOG.md Outdated Show resolved Hide resolved
…w how the whole graphql response looks like.
@o0Ignition0o o0Ignition0o enabled auto-merge (squash) December 22, 2022 09:07
@o0Ignition0o o0Ignition0o merged commit c05c491 into dev Dec 22, 2022
@o0Ignition0o o0Ignition0o deleted the bnjjj/fix_2301 branch December 22, 2022 09:20
@abernix abernix added this to the v1.7.0 milestone Dec 22, 2022
@abernix abernix mentioned this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve response on invalid query variables
4 participants