-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #2257
update dependencies #2257
Conversation
@Geal, please add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could just make the configuration change from usize to NonZeroUsize and not document it. There are much more substantial changes taking place to config and we are calling them "compatible". Maybe mark it as a "breaking" change in the changelog.
my view here is that it does not really make sense to set the capacity to zero. I'm not sure there are cases where we would want to disable the cache entirely, except when debugging, and even then I have not felt the need for it |
Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
some dependency updates require more invloved changes. Here LRU now requires a NonZeroUsize for the capacity argument. This changes the minimal value in the configuration file. Do we consider that this is a breaking change?