Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't decode twice #2249

Merged
merged 7 commits into from
Dec 19, 2022
Merged

Don't decode twice #2249

merged 7 commits into from
Dec 19, 2022

Conversation

neominik
Copy link
Contributor

Since the fix is pretty simple, I made a PR. Fixes #2248

@apollo-cla
Copy link

@neominik: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@o0Ignition0o
Copy link
Contributor

Oh interesting! I'll have a look at it today, since this will have moved in #2170

@o0Ignition0o
Copy link
Contributor

the tests fail because the branch isnt up to date with dev, do you mind merging dev into your branch? :)

Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Let's add a changelog section and land this tomorrow!

@neominik
Copy link
Contributor Author

neominik commented Dec 14, 2022

Great. Thanks for looking into this! I'm not entirely sure how the changelog thing is supposed to work, because there is NEXT_CHANGELOG which is empty and CHANGELOG which contains all the changes, but not for upcoming releases. So would be nice if you could put this into the right place in the correct format. (Feel free to use a better description)

### Wrong urldecoding for variables in get requests ([Issue #2248](https://github.com/apollographql/router/issues/2248))

Using APQs, any '+' characters would be replaced by spaces in variables, breaking for instance datetimes with timezone info.

By [@neominik](https://github.com/neominik) in https://github.com/apollographql/router/pull/2249

(edit: I've put the entry into the changelog now)

@bnjjj bnjjj merged commit 470ee34 into apollographql:dev Dec 19, 2022
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks! 🎉

@abernix abernix added this to the v1.7.0 milestone Dec 22, 2022
@abernix abernix mentioned this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong urldecoding for variables in get requests
6 participants