-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't decode twice #2249
Don't decode twice #2249
Conversation
@neominik: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Oh interesting! I'll have a look at it today, since this will have moved in #2170 |
the tests fail because the branch isnt up to date with dev, do you mind merging dev into your branch? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Let's add a changelog section and land this tomorrow!
Great. Thanks for looking into this! I'm not entirely sure how the changelog thing is supposed to work, because there is NEXT_CHANGELOG which is empty and CHANGELOG which contains all the changes, but not for upcoming releases. So would be nice if you could put this into the right place in the correct format. (Feel free to use a better description) ### Wrong urldecoding for variables in get requests ([Issue #2248](https://github.com/apollographql/router/issues/2248))
Using APQs, any '+' characters would be replaced by spaces in variables, breaking for instance datetimes with timezone info.
By [@neominik](https://github.com/neominik) in https://github.com/apollographql/router/pull/2249 (edit: I've put the entry into the changelog now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks! 🎉
Since the fix is pretty simple, I made a PR. Fixes #2248