silence tests which otherwise are outputting text to terminal #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the TestHarness executes in tests, the list of plugins for the associated router factory is output to the terminal. This change annotates the tests to ensure that a subscriber is provided for the tests which consumes the log text and means it isn't sent to the terminal.
|
@garypen your pull request is missing a changelog! |
o0Ignition0o
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the TestHarness executes in tests, the list of plugins for the
associated router factory is output to the terminal. This change
annotates the tests to ensure that a subscriber is provided for the
tests which consumes the log text and means it isn't sent to the
terminal.