Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HealthCheck Support #54

Closed
o0Ignition0o opened this issue Sep 23, 2021 · 0 comments · Fixed by #252
Closed

HealthCheck Support #54

o0Ignition0o opened this issue Sep 23, 2021 · 0 comments · Fixed by #252
Assignees
@garypen

Comments

@o0Ignition0o
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The TS server implementations provide a healthcheck endpoint and an onHealthCheck callback, we might want to provide one as well

Describe the solution you'd like
We could provide a healthcheck endpoint that returns a simple 200 status code and { status: 'pass' } for now.

Describe alternatives you've considered
As a follow up we could expose user defined callbacks ( impl Future<Output = ()> ) we could await with a timeout, or directives or anything, this would probably require deeper thoughts though.
@o0Ignition0o o0Ignition0o transferred this issue from another repository Nov 4, 2021
@abernix abernix added 2021-12 and removed 2021-11 labels Dec 3, 2021
@garypen garypen mentioned this issue Dec 8, 2021
Merged
@garypen garypen self-assigned this Dec 9, 2021
garypen added a commit that referenced this issue Dec 9, 2021
@garypen
Add a basic health check to the router (#252)
7afbd7d 
* Add a basic health check to the router

Provide a health check endpoint which behaves in the same way as the
health check on the gateway.

At this point in time it always returns pass because we don't have a
different health status to set.

resolves: #54
@o0Ignition0o o0Ignition0o mentioned this issue Jan 11, 2022
Merged
o0Ignition0o added a commit that referenced this issue Jan 11, 2022
@o0Ignition0o
release v0.1.0-alpha.3 (#314)
ba50765 
# [v0.1.0-alpha.3] 2022-01-11

## 🚀🌒 Public alpha release

> An alpha or beta release is in volatile, active development. The release might not be feature-complete, and breaking API changes are possible between individual versions.

## ✨ Features

- Trace sampling [#228](#228): Tracing each request can be expensive. The router now supports sampling, which allows us to only send a fraction of the received requests.

- Health check [#54](#54)

## 🐛 Fixes

- Schema parse errors [#136](#136): The router wouldn't display what went wrong when parsing an invalid Schema. It now displays exactly where a the parsing error occurred, and why.

- Various tracing and telemetry fixes [#237](#237): The router wouldn't display what went wrong when parsing an invalid Schema. It now displays exactly where a the parsing error occurred, and why.

- Query variables validation [#62](#62): Now that we have a schema parsing feature, we can validate the variables and their types against the schemas and queries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garypen garypen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a basic health check to the router apollographql/router
3 participants
@garypen @abernix @o0Ignition0o