Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtask doesn't build w/o openssl installed #2904

Closed
EverlastingBugstopper opened this issue Apr 4, 2023 · 0 comments · Fixed by #2905
Closed

xtask doesn't build w/o openssl installed #2904

EverlastingBugstopper opened this issue Apr 4, 2023 · 0 comments · Fixed by #2905
Assignees

Comments

@EverlastingBugstopper
Copy link
Contributor

EverlastingBugstopper commented Apr 4, 2023

I'm trying to avoid installing brew on my machine for personal reasons, and openssl 1.1.1 seems to be fairly impossible to build and install from source and generally skeeves me out (sudo make install on a macbook feels... fraught).

Regardless, I would like rust-analyzer to work OK without needing too much extra configuration and so I would like to propose vendoring openssl in that workspace crate.

If you run this command, you'll see that it's being brought in by the git2 crate.

cargo metadata --format-version 1 | jq -c '.packages[] | select(.dependencies | any((.name == "openssl-sys"))) | .name'
"git2"
"libgit2-sys"
"libssh2-sys"

The git2 crate has a vendored-openssl feature, we should enable it.

abernix pushed a commit that referenced this issue Apr 5, 2023
This PR enables the `vendored-openssl` feature on the `git2` crate in
the `xtask` workspace crate.

Fixes #2904
garypen pushed a commit that referenced this issue Apr 6, 2023
This PR enables the `vendored-openssl` feature on the `git2` crate in
the `xtask` workspace crate.

Fixes #2904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant