Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return an error on duplicate keys in configuration #1428

Closed
Geal opened this issue Jul 21, 2022 · 1 comment · Fixed by #2270
Closed

return an error on duplicate keys in configuration #1428

Geal opened this issue Jul 21, 2022 · 1 comment · Fixed by #2270
Assignees
@bnjjj

Comments

@Geal
Copy link
Contributor

Geal commented Jul 21, 2022

when there are duplicate keys in the configuration files, serde-yaml only takes the last one. We should return an error instead. A solution is outlined here: dtolnay/serde-yaml#150
@abernix abernix added this to the v1.0.0-rc.X milestone Sep 2, 2022
@BrynCooke
Copy link
Contributor

BrynCooke commented Sep 12, 2022 •
edited
Loading

Is there a specific case where this happens? I checked a couple of locations and it looks like the json schema catches duplicates.
Found one:

telemetry:
  tracing:
    trace_config:
      attributes:
        foo: bar
        foo: bar

@o0Ignition0o o0Ignition0o modified the milestones: v1.0.0-rc.0, post-v1.0 Sep 12, 2022
@abernix abernix removed this from the v1.x.x milestone Oct 17, 2022
@bnjjj bnjjj self-assigned this Dec 14, 2022
@bnjjj bnjjj mentioned this issue Dec 14, 2022
Merged
bnjjj added a commit that referenced this issue Dec 19, 2022
@bnjjj
fix(config): throw an error if we detect duplicated keys in the yaml …
c3d01ca 
…configuration (#2270)

close #1428

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@abernix abernix added this to the v1.7.0 milestone Dec 22, 2022
@abernix abernix mentioned this issue Dec 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@Geal @BrynCooke @abernix @bnjjj @o0Ignition0o