This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Use ApolloClient#stop to clean up MockedProvider client. #2741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was introduced in apollo-client@2.4.12: apollographql/apollo-client#4336
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Jan 19, 2019
This reverts commit 9739ff6. Now that we have a uniform interface for terminating ApolloClient instances (#4336), there should be no need for any external code to access the QueryScheduler abstraction, which this commit removes. We should wait to merge and release this change until after apollographql/react-apollo#2741 has been merged and released, so that we don't break older versions of MockedProvider.
danilobuerger
approved these changes
Jan 19, 2019
|
Works on my machine 😅 |
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Jan 22, 2019
This reverts commit 9739ff6. Now that we have a uniform interface for terminating ApolloClient instances (#4336), there should be no need for any external code to access the QueryScheduler abstraction, which this commit removes. We should wait to merge and release this change until after apollographql/react-apollo#2741 has been merged and released, so that we don't break older versions of MockedProvider.
benjamn
added a commit
to apollographql/apollo-client
that referenced
this pull request
Jan 22, 2019
This reverts commit 9739ff6. Now that we have a uniform interface for terminating ApolloClient instances (#4336), there should be no need for any external code to access the QueryScheduler abstraction, which this commit removes. We should wait to merge and release this change until after apollographql/react-apollo#2741 has been merged and released, so that we don't break older versions of MockedProvider.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
stopmethod was introduced in apollo-client@2.4.12: apollographql/apollo-client#4336Credit to @danilobuerger for suggesting we hide the details of stopping the
MockedProviderclient using a newApolloClientmethod: https://apollographql.slack.com/archives/C2FERSTGC/p1547849096341900The
stopmethod would have made #2738 a non-issue, since we could easily change the implementation ofstopwithout affecting its consumers.