chore(deps): update dependency apollo-link to v1.2.3 - autoclosed

[renovate]

This PR contains the following updates:

Package	Type	Update	Change	References
apollo-link	devDependencies	patch	1.2.1 -> 1.2.3	source

---

Renovate configuration

📅 Schedule: PR created on schedule "after 10pm every weekday,before 5am every weekday" in timezone America/Los_Angeles

🚦 Automerge: Enabled.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

This PR has been generated by Renovate Bot. View repository job log here.

[renovate]

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

[hwillson]

Something very interesting is happening here, and I have a feeling Renovate has inadvertently given us multiple reproductions that show unnecessary re-renders happening with react-apollo. Updating to the latest apollo-client and apollo-link-http versions (so going past what renovate is doing here), and fixing the type errors, brings back a new round of test failures. Each of those test failures are being caused by the number of expected renders happening in tests now being off by 1.

Flagging this PR as high-priority.

@cheapsteak @justinanastos - this is the issue I was referring to when we spoke last, that might help explain why you were seeing unnecessary renders. Some recent combination of apollo-client, react-apollo, and apollo-link-http is causing this.

[hwillson]

Just to add - some of the other test failures are being caused by the fact that react-apollo tests have been updated to use graphql 14, whereas apollo-client is still expecting graphql 0.13.x 🙁. We really need to get AC updated, but we're currently held up by apollo-utilities (see apollographql/apollo-client#4233).