-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor createHandler
to createHandlerFromSchema
#83
Merged
Merged
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
958c625
wip
alessbell 7603bc1
save progress
alessbell 90318f4
save progress
alessbell 6913889
chore: fix merge conflict
alessbell 9d1dc27
chore: refactor
alessbell d88d254
chore: adds changeset
alessbell 256d939
chore: simplify types
alessbell b072535
fix: do not lint generated filed
alessbell 1e22429
wip
alessbell e5b67f2
chore: fix tests and add MSW license requestHandler file
alessbell 29d42a9
fix: handlers.test.tsx
alessbell 25ccc99
chore: update ecommerce-schema.graphql and rerun codegen
alessbell 56cb458
chore: remove createSchema.ts
alessbell 934fd31
chore: remove unneeded mock
alessbell 035267b
chore: update dependencies and lockfile
alessbell 66407e7
chore: fix merge conflict
alessbell f1e8cba
chore: remove redundant dev dependencies
alessbell bb4d2bc
chore: fix merge conflict
alessbell d7814b6
chore: fix more merge conflicts
alessbell 4bdd4e6
chore: update changeset
alessbell d476674
chore: use minor version
alessbell 674da60
chore: add withMocks function
alessbell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@apollo/graphql-testing-library": patch | ||
--- | ||
|
||
Adds `createHandlerFromSchema` | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
pnpm-lock.yaml | ||
.storybook/public/mockServiceWorker.js | ||
.storybook/public/mockServiceWorker.js | ||
__generated__ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
225 changes: 109 additions & 116 deletions
225
.storybook/stories/components/relay/__generated__/RelayComponentAppQuery.graphql.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you've also added a bunch of exports for utilities. Would that be worth calling out here or in a separate changeset?
I've also noticed that
createHandlerFromSchema
is more-or-less the same ascreateHandler
was before this since the oldcreateHandler
took aschema
as an argument. Would it be worth calling out that breaking change to specify thatcreateHandler
now accepts type defs and provides a bunch of the default resolvers for you?