Skip to content

[docs] Update @fromContext directive to use federation type #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[docs] Update @fromContext directive to use federation type #3313

wants to merge 1 commit into from

Conversation

smyrick
Copy link
Member

@smyrick smyrick commented Oct 10, 2025

Fix the reference Federation spec in docs. This SDL is not valid. The federation__ prefix may be removed in libraries using @link, however we define the scalar above with the prefix

@smyrick
Update @fromcontext directive to use federation type
9e1c78b 
This SDL is not valid. The `federation__` prefix may be removed in libraries using `@link`, however we define the scalar above with the prefix
@smyrick smyrick requested a review from a team as a code owner October 10, 2025 19:14
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2025

⚠️ No Changeset found

Latest commit: 9e1c78b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@apollo-librarian
Copy link

apollo-librarian bot commented Oct 10, 2025 •
edited
Loading

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed 
* graphos/schema-design/federated-schemas/reference/subgraph-spec.mdx

Build ID: ec4d2737dd96e89651285a0a
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/ec4d2737dd96e89651285a0a

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@smyrick smyrick enabled auto-merge (squash) October 10, 2025 21:24
smyrick
smyrick commented Oct 10, 2025
View reviewed changes
docs/source/schema-design/federated-schemas/reference/subgraph-spec.mdx
directive @policy(policies: [[federation__Policy!]!]!) on FIELD_DEFINITION | OBJECT | INTERFACE | SCALAR | ENUM
directive @context(name: String!) repeatable on INTERFACE | OBJECT | UNION
directive @fromContext(field: ContextFieldValue) on ARGUMENT_DEFINITION
directive @fromContext(field: federation__ContextFieldValue) on ARGUMENT_DEFINITION
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See line 41: https://github.com/apollographql/federation/pull/3313/files#diff-c30b0600ec2a4cd8f102a03f1e677adb189b8fc95ff7900b36037264874eabf5R41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@smyrick