fix(composition): Use a priority queue instead of a stack for satisfiability #3258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… highly connected supergraphs
🦋 Changeset detectedLatest commit: 252cc9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sachindshinde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates satisfiability logic to use a (heap-based) priority queue instead of a stack to store validation state, where a state is higher priority if it has less possible subgraph paths. This is because supergraphs with high connectivity can lead to states with many possible subgraph paths for a supergraph path, and repeatedly processing such states can cause an explosion in possible subgraph paths in the worst case. To avoid this explosion, we prioritize supergraph paths with fewer possible subgraph paths, and this helps us reach more types using smaller states in practice. Loop detection then prevents us from having to consider the larger states to begin with.