Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inefficient query plans when using @context #3140

Merged
merged 17 commits into from
Oct 15, 2024
Merged

inefficient query plans when using @context #3140

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ff5e2fa
Query plans that incorporated contextual variables could be inefficie…
clenfest Aug 19, 2024
9888268
Argument naming was incorrect because it was occurring inside of loop…
clenfest Sep 9, 2024
2ec181e
add changeset
clenfest Sep 9, 2024
f473842
get rid of whitespace only changes
clenfest Sep 11, 2024
f117c6d
Merge branch 'main' into clenfest/zzz
clenfest Sep 13, 2024
fcf48af
prettier and cspell fix
clenfest Sep 13, 2024
8b14505
Merge branch 'main' into clenfest/zzz
clenfest Sep 16, 2024
df44700
Merge branch 'main' into clenfest/zzz
clenfest Sep 16, 2024
ab3dfcf
Merge branch 'main' into clenfest/zzz
clenfest Sep 17, 2024
27b5860
basic requires test
clenfest Sep 20, 2024
310b23d
Merge branch 'main' into clenfest/zzz
clenfest Sep 30, 2024
0997fb7
simplifying handleRequires
clenfest Sep 30, 2024
b92e52f
refactoring
clenfest Sep 30, 2024
efce70b
Adjust calling code for split handleRequires(), paired with @clenfest
sachindshinde Oct 15, 2024
ff59e97
Merge remote-tracking branch 'upstream/main' into clenfest/zzz
sachindshinde Oct 15, 2024
4f584d0
Revert unintended test changes from before
sachindshinde Oct 15, 2024
a04979f
add .gitleaksignore file
clenfest Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/fuzzy-readers-happen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@apollo/query-planner": patch
"@apollo/query-graphs": patch
---

Fixes edge case where contextual arguments can yield inefficient query plans. Also fixes naming of query plan arguments which can be a problem when using contextual variables in multiple subgraphs
Loading