Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key selects a field on a value type #225

Open
wants to merge 1 commit into
base: version-0.x
Choose a base branch
from

Conversation

tinnou
Copy link
Contributor

@tinnou tinnou commented Oct 12, 2020

I'm trying to understand why @key fieldSet can not reference a field on a value type? In other words, why is below not allowed?

          extend type Car @key(fields: "model { name kit { upc } }") {
              model: Model! @external
          }
          type Model {
              name: String!
              kit: Kit
          }
          type Kit {
              upc: String!
          }

I added a test that fails validation to reproduce.

@apollo-cla
Copy link

@tinnou: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants