Insert empty Subscription type definition #212
Conversation
|
@abernix Is there a way to rerun the checks without pushing a new commit? It looks like the test runner itself failed during initialization. |
|
@abernix Hey, I don't want to bug you but I would like to get this merged in or rejected. Thanks! |
|
@trevor-scheer Could I get some eyes on this? It's pretty minor and I'd like to close it. |
|
Hello guys! The error is:
Debugging the Apollo Federation packages, I ended up arriving at the same solution as this PR. |
| @@ -58,6 +58,12 @@ const EmptyMutationDefinition = { | |||
| fields: [], | |||
| serviceName: null, | |||
| }; | |||
| const EmptySubscriptionDefinition = { | |||
| kind: Kind.OBJECT_TYPE_DEFINITION, | |||
| name: { kind: Kind.NAME, value: 'Subscription' }, | |||
There was a problem hiding this comment.
Can we use a constant here?
Like this:
name: { kind: Kind.NAME, value: defaultRootOperationNameLookup.subscription },
There was a problem hiding this comment.
@Chase-C can I help you with this PR?
There was a problem hiding this comment.
Be my guest. I tried making the change you suggested, but I'm not sure it's possible to push new commits to this branch without creating an entirely new PR (this one was migrated from the apollo-server project).
There was a problem hiding this comment.
I tried here, and really need create a new PR with fork. Do you want to create there? Or do I create here?
|
@abernix can you help us with this PR? |
Fixes the issue I brought up in #4102
Originally at: apollographql/apollo-server#4148