Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about the behavior of shareable value types declared on subgraphs using fed. 1 and fed. 2 #2014

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mNalon
Copy link
Contributor

@mNalon mNalon commented Jul 26, 2022

Adding a note about the behavior of the shareable value types regarding the composition result, when these value types are declared on subgraphs using both fed.1 and fed.2.

I had to test it and confirm with the apollo team to guarantee that it would work. Maybe this note will be useful for anyone else reading the doc.

@netlify
Copy link

netlify bot commented Jul 26, 2022

👷 Deploy request for apollo-federation-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5e8198a

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 26, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've requested a small copyedit if that works for you 🙏

docs/source/federation-2/moving-to-federation-2.mdx Outdated Show resolved Hide resolved
docs/source/federation-2/moving-to-federation-2.mdx Outdated Show resolved Hide resolved
mNalon and others added 2 commits August 15, 2022 20:59
Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com>
Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants