Fix issues with use of type condition in a @require (fed1 version) #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2022 16:07
When a `@require` add nested selections, the `__typename` of the nested object was not queried in the query plans. If that `@require` selection also some conditional selection (fragments with type condition), then the lack of `__typename` meant that the execution code was not able to correctly identify the proper data to send to subgraphs (it couldn't say the type of the data fetched, and so when computed what should be included for the `@require`, those conditional selection couldn't be evaluated properly). This commit fixes the issue by ensure we always query `__typename` for nested objects within `@require`. Fixes apollographql#1867.
…uire This is the fed1 version of the fed2 patch at apollographql#1873. Seen that PR/commit for more details.
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.