-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OTel-JS broken link #1302
Update OTel-JS broken link #1302
Conversation
This PR does the following, Updates the link to "Getting Started" to the [most recent link provided in the OTel-JS Repo](https://github.com/open-telemetry/opentelemetry-js/blob/main/README.md?plain=1#L5) This change in linking is documented in OTel-JS [commit apollographql#2493](open-telemetry/opentelemetry-js#2493)
@MannyPamintuanAtCare: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
🚀 ✨ 🌕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your 🌍 -improving hyperlink-awareness! LGTM.
(If you wanted to also do this on the main
branch, that'd be much appreciated, but I can follow-up myself if not. 😉 )
Per @abernix's [great suggestion](apollographql#1302 (review)), this PR does the following, - Updates the link to "Getting Started" to the [most recent link provided in the OTel-JS Repo](https://github.com/open-telemetry/opentelemetry-js/blob/main/README.md?plain=1#L5) - This change in linking is documented in OTel-JS [commit apollographql#2493](open-telemetry/opentelemetry-js#2493)
You're most welcome, Jesse (@abernix)! |
Thanks! |
This PR does the following,
Updates the link to "Getting Started" to the most recent link provided in the OTel-JS Repo
This change in linking is documented in OTel-JS commit #2493