Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema caching for multi-schema workspaces #179

Merged
merged 2 commits into from
Nov 15, 2018

Conversation

patsissons
Copy link

@patsissons patsissons commented Oct 20, 2018

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the README

Pull Request Labels

  • feature
  • blocking
  • docs

resolves #178

@apollo-cla
Copy link

@patsissons: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added the blocking Prevents production or dev due to perf, bug, build error, etc.. label Oct 20, 2018
@patsissons patsissons force-pushed the fix-schema-caching branch 3 times, most recently from 26f4728 to 4d8f6cc Compare October 22, 2018 19:33
@BPScott
Copy link

BPScott commented Nov 13, 2018

Ping @stubailo, as part of your recent flurry of updates, would it be possible to take a look at this? It's currently blocking a project of mine and @patsissons' from updating to the latest version.

@stubailo
Copy link
Contributor

@BPScott right now I have 3 goals:

  1. Fix the required-field rule to always work when fragments are involved Required fields and fragments #199
  2. Add an auto-fix for that rule
  3. Make sure schema loading is reliable, especially in the case of schemas changing while your editor is open

That said, let me take a look

@stubailo
Copy link
Contributor

It seems like a pretty safe change 🤔 can you rebase and I'll try to release it?

@stubailo stubailo self-assigned this Nov 13, 2018
@stubailo
Copy link
Contributor

(Also that will ensure the build passes)
(Also sorry I moved some of the tests around, so hope it's not too bad)

@patsissons
Copy link
Author

no rebase conflicts 👍

@stubailo stubailo merged commit ea4e38a into apollographql:master Nov 15, 2018
@stubailo
Copy link
Contributor

🎉

@stubailo
Copy link
Contributor

published in 3.0.1 - can you tag me on any relevant issues to be closed?

@patsissons
Copy link
Author

#178 should be closed now thanks to resolved keyword in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Prevents production or dev due to perf, bug, build error, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema caching broken for multiple schemas since 2.1.0
4 participants