New throwIfResponseIsError hook #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously removed `didReceiveResponse` which let you override the main "is it an error or not" logic. This restores it in an error-specific way. This means you can throw errors even on 200s if you want (or vice versa). This also changes the `errorFromResponse` hook to take options instead of a single argument, in case you want the error to reflect more data. One negative change is you can no longer prevent `parseBody` from being called, though you can always override `parseBody` to do less. Fixes #32.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
This does conflict a bit with #110, sorry. I didn't update README because the original hook wasn't documented. At some point I think you do need to assume that people who want to customize by overriding protected methods will just read the source... |
trevor-scheer
approved these changes
Dec 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously removed
didReceiveResponsewhich let you override the main "is it an error or not" logic. This restores it in an error-specific way. This means you can throw errors even on 200s if you want (or vice versa).This also changes the
errorFromResponsehook to take options instead of a single argument, in case you want the error to reflect more data.One negative change is you can no longer prevent
parseBodyfrom being called, though you can always overrideparseBodyto do less.Fixes #32.