Use DefinitelyTyped for http-cache-semantics, let you pass options to it #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lyTyped We sneakily add a few fields back in, and we add a check for a potential issue that our types masked before.
Fixes #53. This is based on apollographql/apollo-server#4306 by @harleynuss. While it's generally not great to base our API on another package's API, `http-cache-semantics` has been pretty stable, and if it makes major changes we can always major-bump this package. Because a type from `http-cache-semantics` is now part of our API, this makes its DefinitelyTyped package a non-dev dependency. While we're there, I noticed that `@apollo/utils.keyvaluecache` had a strict dependency which I changed to a caret. I originally wanted to make `httpCacheSemanticsCachePolicyOptions` part of `CacheOptions` (next to `ttl`) but that function gets called *after* the request is made (with the response as an argument), which is too late.
|
I might do #65 as part of the same PR in a third commit. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
trevor-scheer
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Cache semantics options lgtm. Just re-request if you choose to do #65 as well and I can take another pass.
|
Eh I can merge and do it separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review individual commits.