Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CacheOptions Related Types #267

Closed
HishamAli81 opened this issue Oct 10, 2023 · 1 comment · Fixed by #268
Closed

Fix CacheOptions Related Types #267

HishamAli81 opened this issue Oct 10, 2023 · 1 comment · Fixed by #268

Comments

@HishamAli81
Copy link
Contributor

Problem:

There are a couple issues with the CacheOptions related types.

First, the RequestOptions.cacheOptions function returns a Promise<CO | undefined>, whereas the RESTDataSource.cacheOptionsFor() and HttpCache.fetch() functions both accept a function that returns ValueOrPromise<CO | undefined>.

Second, there are a number of places where the CO cache option generics argument is being propagated through to RequestOptions and AugmentedRequest
HishamAli81 pushed a commit to HishamAli81/datasource-rest-GH-267 that referenced this issue Oct 10, 2023
@hisham-otofacts
fix: [apollographqlGH-267] Fix CacheOptions Related Types
c6d63e3 
* Fix RequestOptions.cacheOptions function return type to also return a non-promise value.
* Fix propagation of the cache options generic type `RequestOptions` and `AugmentedRequest`.
@HishamAli81
Copy link
Contributor Author

I've created this PR to fix some of the type issues: #268. It's a follow up to this PR: #185 that I created & was already merged.

HishamAli81 pushed a commit to HishamAli81/datasource-rest-GH-267 that referenced this issue Oct 17, 2023
@hisham-otofacts
fix: [apollographqlGH-267] generic args
0e8001c 
Update generic args when calling policyRequestFrom()
trevor-scheer pushed a commit to HishamAli81/datasource-rest-GH-267 that referenced this issue Oct 17, 2023
@hisham-otofacts @trevor-scheer
fix: [apollographqlGH-267] Fix CacheOptions Related Types
bb512e9 
* Fix RequestOptions.cacheOptions function return type to also return a non-promise value.
* Fix propagation of the cache options generic type `RequestOptions` and `AugmentedRequest`.
trevor-scheer pushed a commit to HishamAli81/datasource-rest-GH-267 that referenced this issue Oct 17, 2023
@hisham-otofacts @trevor-scheer
fix: [apollographqlGH-267] generic args
dc77590 
Update generic args when calling policyRequestFrom()
@trevor-scheer trevor-scheer mentioned this issue Oct 17, 2023
Merged
HishamAli81 pushed a commit to HishamAli81/datasource-rest-GH-267 that referenced this issue Oct 18, 2023
@hisham-otofacts
feat: [apollographqlGH-267] Resolved merge conflicts
4f31a28
trevor-scheer pushed a commit that referenced this issue Oct 18, 2023
@HishamAli81
fix: [GH-267] Fix CacheOptions Related Types (#268)
870ba80 
* Fix RequestOptions.cacheOptions function return type to also return a non-promise value.
* Fix propagation of the cache options generic type RequestOptions and AugmentedRequest.

Fixes #267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [GH-267] Fix CacheOptions Related Types HishamAli81/datasource-rest-GH-267
1 participant
@HishamAli81