Use lodash's cloneDeep to clone parsed body (#270)

.changeset/fluffy-ants-appear.md

@@ -0,0 +1,5 @@
+---
+'@apollo/datasource-rest': patch
+---
+
+Use lodash's `cloneDeep` to clone parsed body instead of `JSON.parse(JSON.stringify(...))`

cspell-dict.txt

@@ -7,6 +7,7 @@ careted
 changesets
 cimg
 circleci
+clonedeep
 codesandbox
 concat
 datasource

package.json

@@ -36,6 +36,7 @@
     "@changesets/changelog-github": "0.4.8",
     "@changesets/cli": "2.26.2",
     "@types/jest": "29.5.5",
+    "@types/lodash.clonedeep": "4.5.7",
     "@types/lodash.isplainobject": "4.0.7",
     "@types/node": "16.18.58",
     "@typescript-eslint/eslint-plugin": "6.7.5",
@@ -59,6 +60,7 @@
     "@apollo/utils.withrequired": "^3.0.0",
     "@types/http-cache-semantics": "^4.0.1",
     "http-cache-semantics": "^4.1.1",
+    "lodash.clonedeep": "^4.5.0",
     "lodash.isplainobject": "^4.0.6",
     "node-fetch": "^2.6.7"
   },

src/RESTDataSource.ts

@@ -4,12 +4,13 @@ import type {
   FetcherResponse,
 } from '@apollo/utils.fetcher';
 import type { KeyValueCache } from '@apollo/utils.keyvaluecache';
+import type { Logger } from '@apollo/utils.logger';
 import type { WithRequired } from '@apollo/utils.withrequired';
 import { GraphQLError } from 'graphql';
+import type { Options as HttpCacheSemanticsOptions } from 'http-cache-semantics';
+import cloneDeep from 'lodash.clonedeep';
 import isPlainObject from 'lodash.isplainobject';
 import { HTTPCache } from './HTTPCache';
-import type { Logger } from '@apollo/utils.logger';
-import type { Options as HttpCacheSemanticsOptions } from 'http-cache-semantics';
 
 export type ValueOrPromise<T> = T | Promise<T>;
 
@@ -326,11 +327,8 @@ export abstract class RESTDataSource<CO extends CacheOptions = CacheOptions> {
   }
 
   protected cloneParsedBody<TResult>(parsedBody: TResult) {
-    if (typeof parsedBody === 'string') {
-      return parsedBody;
-    } else {
-      return JSON.parse(JSON.stringify(parsedBody));
-    }
+    // consider using `structuredClone()` when we drop support for Node 16
+    return cloneDeep(parsedBody);
   }
 
   protected shouldJSONSerializeBody(body: RequestWithBody['body']): boolean {