Fix specified lru-cache version range and update @types/node version
#226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0757e15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Looks like the pin is a Node 12 issue (isaacs/node-lru-cache#247 (comment)). Can we just remove it and see if upgrading works fine? (The comment suggests there might be other issues with the TS compatibility but we would presumably learn about that quickly.) Then perhaps do a v1 backport of a similar commit? |
glasser
approved these changes
Nov 23, 2022
trevor-scheer
changed the title
lru-cache version rangelru-cache version range and update @types/node version
Merged
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced as a consequence of the renovate config I created:
cab3444 (from #169)
Issue raised by @SimenB here:
#169 (comment)
This PR also updates the
@types/nodeversion to 14, which should've been done as part of dropping node 12 support and happens to be a requirement for this PR.