-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AS4 migration guide - one more editing pass #6751
Conversation
rkoron007
commented
Jul 29, 2022
- adding the disclaimer component to the "getting started" article, instead of hard-coding that language.
|
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0c2e253:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some miscellaneous copy tweaks!
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
@rkoron007 don't mind the smoke test failure, that's definitely not on you. Maybe some flakiness @glasser and I need to take a look at. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed this PR and it generally looks great! I know you and Trevor have had several rounds already so I'm not surprised that I don't have much left to say :)