Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS4 migration guide - one more editing pass #6751

Merged
merged 14 commits into from
Aug 5, 2022

Conversation

rkoron007
Copy link
Contributor

  • adding the disclaimer component to the "getting started" article, instead of hard-coding that language.

@rkoron007 rkoron007 added the 📝 documentation Focuses on changes to the documentation (docs) label Jul 29, 2022
@rkoron007 rkoron007 self-assigned this Jul 29, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2022

⚠️ No Changeset found

Latest commit: 0c2e253

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit 0c2e253
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/62ed6f51717057000863be28
😎 Deploy Preview https://deploy-preview-6751--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 29, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c2e253:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

Copy link
Contributor

@StephenBarlow StephenBarlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some miscellaneous copy tweaks!

docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
rkoron007 and others added 2 commits August 2, 2022 07:49
Co-authored-by: Stephen Barlow <stephen@apollographql.com>
docs/source/migration.mdx Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
docs/source/migration.mdx Outdated Show resolved Hide resolved
Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
@trevor-scheer
Copy link
Member

@rkoron007 don't mind the smoke test failure, that's definitely not on you. Maybe some flakiness @glasser and I need to take a look at.

Copy link
Member

@glasser glasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed this PR and it generally looks great! I know you and Trevor have had several rounds already so I'm not surprised that I don't have much left to say :)

docs/source/migration.mdx Outdated Show resolved Hide resolved
@rkoron007 rkoron007 merged commit f87d67a into version-4 Aug 5, 2022
@rkoron007 rkoron007 deleted the RK/AS4-migration-second-pass branch August 5, 2022 19:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📝 documentation Focuses on changes to the documentation (docs)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants