-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CI: test on Node 16, switch to newer cimg images (#5137)
Node 16.0.0 is now released; we should run CI against it. The older circleci/node Docker images we use in the Apollo OSS orb do not yet have 16.0.0. It seems reasonable to switch over to the "non legacy" cimg/node Docker images anyway. Those images don't have "major version" tags like 16, just tags like 16.0.0 and 16.0. So let's switch over to specifying images directly in config.yml rather than via our orb, and let Renovate update it. See https://github.com/renovatebot/renovate/blob/92aab2b30f5c0d811056a1574354e97057c42732/lib/manager/circleci/extract.ts#L49 for what Renovate is looking for. This PR does not convert to using npm v7 (and its new package-lock.json format); we should do that soon.
- Loading branch information
Showing
3 changed files
with
16 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"engines": { | ||
"node": ">=14 <15", | ||
"node": ">=16 <17", | ||
"npm": "6.x" | ||
}, | ||
"scripts": { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters