Skip to content

Commit

Permalink
Test against Node v22 (#7903)
Browse files Browse the repository at this point in the history
Update CCI config to test against Node 22 as well
  • Loading branch information
trevor-scheer authored Jul 22, 2024
1 parent 86d7111 commit 6af412e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 2 additions & 0 deletions .changeset/seven-brooms-impress.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ workflows:
- "16"
- "18"
- "20"
- "22"
- "Check for FIXM\x45"
- Prettier
- ESLint
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,8 @@ Object.keys(schemes).forEach((schemeName) => {
// idle connections in these versions. However, `Stopper` _is_ still
// useful for gracefully finishing in-flight requests within the timeout
// (and aborting requests beyond the timeout).
//
// (Node 18.19.0 had this change backported but it was removed again in
// 18.20.3; our tests only pin major versions so we can assume 18 means
// >= 18.20.3.)
const isNode20 = !!process.version.match(/^v20\./);
expect(closed).toBe(isNode20 ? 1 : 0);
const isNode20orGreater = !!process.version.match(/^v2\d\./);
expect(closed).toBe(isNode20orGreater ? 1 : 0);
});

// This test specifically added for Node 20 fails for Node 14. Just going
Expand Down

0 comments on commit 6af412e

Please sign in to comment.