This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Reduce bundlesize limits to reflect recent measurement changes. #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although it's possible that shipping ESM code via the "module" field of package.json may have reduced the size of these packages, the primary reason for the very large reduction in package sizes is that we're no longer bundling in the dependencies, so the new sizes reflect just the packages themselves. Including dependencies in per-package size measurements is misleading because most apps use multiple apollo-link-* packages, so shared dependencies will be included only once in the bundle, and thus should not be counted as part of each individual package's size. Fundamentally, measuring bundle size on a per-package basis doesn't make a whole lot of sense. Instead, we should use an example application that uses a typical/representative set of Apollo packages, and bundles everything together using a modern bundling tool.
JoviDeCroock
approved these changes
Mar 4, 2019
This comment has been minimized.
This comment has been minimized.
|
@JoviDeCroock Here's my latest attempt at whole-application bundle size measurement: apollographql/react-apollo#2839 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it's possible that shipping ESM code via the "module" field of
package.jsonmay have reduced the size of these packages, the primary reason for the very large reduction in package sizes is that we're no longer bundling in the dependencies, so the new sizes reflect just the packages themselves.Including dependencies in per-package size measurements is misleading because most apps use multiple
apollo-link-*packages, so shared dependencies will be included only once in the bundle, and thus should not be counted as part of each individual package's size.Fundamentally, measuring bundle size on a per-package basis doesn't make a whole lot of sense. Instead, we should use an example application that uses a typical/representative set of Apollo packages, and bundles everything together using a modern bundling tool.