Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Chore: update way of building #918

Merged
merged 12 commits into from
Jan 31, 2019
Merged

Chore: update way of building #918

merged 12 commits into from
Jan 31, 2019

Conversation

JoviDeCroock
Copy link
Contributor

@JoviDeCroock JoviDeCroock commented Jan 21, 2019

I've updated the way of building to a more conform approach to standards and the way discussed in apollo-client
apollographql/apollo-client#4261

This covers a

  • tree-shakeable esm bundle
  • jsnext:main is unknown to most bundlers so I removed it
  • an exploded cjs build

@codecov-io
Copy link

Codecov Report

Merging #918 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          20       20           
  Lines         662      662           
  Branches      147      147           
=======================================
  Hits          638      638           
  Misses         19       19           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbfa9a8...348e837. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #918 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files          20       20           
  Lines         662      662           
  Branches      147      147           
=======================================
  Hits          638      638           
  Misses         19       19           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbfa9a8...817a3c4. Read the comment docs.

@JoviDeCroock JoviDeCroock changed the title Chore/update way of building Chore: update way of building Jan 23, 2019
@hwillson hwillson self-assigned this Jan 31, 2019
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @JoviDeCroock - thanks!

@hwillson hwillson merged commit 5813d30 into apollographql:master Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants