Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing factory accessor method for fragments #158

Merged
merged 3 commits into from
Feb 4, 2017
Merged

Fix missing factory accessor method for fragments #158

merged 3 commits into from
Feb 4, 2017

Conversation

sav007
Copy link
Contributor

@sav007 sav007 commented Feb 4, 2017

Part of #142

marwanad
marwanad approved these changes Feb 4, 2017
View reviewed changes
Copy link
Contributor

@marwanad marwanad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to rebase first. I think you might need to make changes to:

https://github.com/apollographql/apollo-android/blob/master/apollo-compiler/src/test/graphql/com/example/fragment_in_fragment/TestQueryExpected.java

@sav007 sav007 merged commit 26c1eb5 into apollographql:master Feb 4, 2017
@sav007 sav007 deleted the bug/fragments-factory branch February 4, 2017 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwanad marwanad marwanad approved these changes

@felipecsl felipecsl felipecsl approved these changes

@digitalbuddha digitalbuddha Awaiting requested review from digitalbuddha

Assignees
No one assigned
Labels
🐛 Type: Bug ⚙️ Codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sav007 @felipecsl @marwanad