Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create FetchOptions to allow GET Requests like in Web #572

Merged
merged 12 commits into from
Jun 26, 2019
Merged

Create FetchOptions to allow GET Requests like in Web #572

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8cb9fb4
create FetchOptions to be used while fetch
Jun 7, 2019
53f2e51
add tests to confirm with FetchOptions
Jun 7, 2019
bea8242
add fetch Options in NetworkTransport
Jun 7, 2019
ad29887
set efault value for fetchOptions as POST
Jun 8, 2019
fcb9533
add default value for fetchOptions in perform
Jun 8, 2019
ef686cb
rename FetchOptions to FetchHTTPMethod
Jun 25, 2019
5ff93a7
fixing tests after rename of fetchOptions to fetchHTTPOptions
Jun 25, 2019
dee434b
remove forced try in JSONSerializationFormat
Jun 25, 2019
2a77206
solving conflicts
Jun 25, 2019
9766548
add POST as default parameter for FetchHTTPMethod in subscribe
Jun 25, 2019
4f92bee
use default parameter in perform tests
Jun 25, 2019
4a97304
explaning better the parameter
Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add POST as default parameter for FetchHTTPMethod in subscribe
  • Loading branch information
Douglas Mandarino authored and Douglas Mandarino committed Jun 25, 2019
commit 9766548cb829aa31af0537d81450a9ca358e91e1
4 changes: 2 additions & 2 deletions Sources/Apollo/ApolloClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public class ApolloClient {
/// - queue: A dispatch queue on which the result handler will be called. Defaults to the main queue.
/// - resultHandler: An optional closure that is called when mutation results are available or when an error occurs.
/// - Returns: An object that can be used to cancel an in progress mutation.
@discardableResult public func perform<Mutation: GraphQLMutation>(mutation: Mutation, fetchHTTPMethod: FetchHTTPMethod, queue: DispatchQueue = DispatchQueue.main, resultHandler: OperationResultHandler<Mutation>? = nil) -> Cancellable {
@discardableResult public func perform<Mutation: GraphQLMutation>(mutation: Mutation, fetchHTTPMethod: FetchHTTPMethod = .POST, queue: DispatchQueue = DispatchQueue.main, resultHandler: OperationResultHandler<Mutation>? = nil) -> Cancellable {
return _perform(mutation: mutation, fetchHTTPMethod: fetchHTTPMethod, queue: queue, resultHandler: resultHandler)
}

Expand All @@ -136,7 +136,7 @@ public class ApolloClient {
/// - queue: A dispatch queue on which the result handler will be called. Defaults to the main queue.
/// - resultHandler: An optional closure that is called when mutation results are available or when an error occurs.
/// - Returns: An object that can be used to cancel an in progress subscription.
@discardableResult public func subscribe<Subscription: GraphQLSubscription>(subscription: Subscription, fetchHTTPMethod: FetchHTTPMethod, queue: DispatchQueue = DispatchQueue.main, resultHandler: @escaping OperationResultHandler<Subscription>) -> Cancellable {
@discardableResult public func subscribe<Subscription: GraphQLSubscription>(subscription: Subscription, fetchHTTPMethod: FetchHTTPMethod = .POST, queue: DispatchQueue = DispatchQueue.main, resultHandler: @escaping OperationResultHandler<Subscription>) -> Cancellable {
return send(operation: subscription, fetchHTTPMethod: fetchHTTPMethod, context: nil, handlerQueue: queue, resultHandler: resultHandler)
}

Expand Down