Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache load errors cause deadlock in write transaction #365

Closed
wants to merge 4 commits into from
Closed

Cache load errors cause deadlock in write transaction #365

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3aca1a3
reject batch loader loads if a loader fails to allow exceptions to ca…
ashiemke Sep 11, 2018
6d68c54
remove unused code
ashiemke Sep 11, 2018
d82066e
fix submodule
ashiemke Sep 11, 2018
6b4bd7d
update test to make sure data will fail to parse
ashiemke Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused code
  • Loading branch information
@ashiemke
ashiemke committed Sep 11, 2018
commit 6d68c547e9ae524fe3a9d07f4fb75134cd0ce7d2
9 changes: 0 additions & 9 deletions Tests/ApolloCacheDependentTests/LoadQueryFromStoreTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,3 @@ class LoadQueryFromStoreTests: XCTestCase {
waitForExpectations(timeout: 5, handler: nil)
}
}

//class JSON: JSONEncodable, JSONDecodable {
// var jsonValue: JSONValue {
// return ["asdf": "123"]
// }
// required init(jsonValue value: JSONValue) throws {
// return
// }
//}