Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ApolloSchemaDownloadConfiguration HTTP headers json #2811

Merged
merged 4 commits into from
Feb 8, 2023
Merged

fix: ApolloSchemaDownloadConfiguration HTTP headers json #2811

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55c0fa5
Refactor decoder to parse HTTP headers as Dictionary
calvincestari Feb 4, 2023
39b54e7
Refactor tests for the supported HTTP header formats
calvincestari Feb 4, 2023
634d8b2
Update Tests/ApolloCodegenTests/ApolloSchemaDownloadConfigurationCoda…
calvincestari Feb 6, 2023
627690b
Update Tests/ApolloCodegenTests/ApolloSchemaDownloadConfigurationCoda…
calvincestari Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Tests/ApolloCodegenTests/ApolloSchemaDownloadConfigurationCoda… 
…bleTests.swift
  • Loading branch information
@calvincestari
calvincestari authored Feb 6, 2023
commit 634d8b248e9978d22c84df2606f7878727de0c57
2 changes: 1 addition & 1 deletion Tests/ApolloCodegenTests/ApolloSchemaDownloadConfigurationCodableTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ApolloSchemaDownloadConfigurationCodableTests: XCTestCase {

// MARK: - ApolloSchemaDownloadConfiguration Tests

func test__encodeApolloSchemaDownloadConfiguration__givenAllParameters_shouldReturnJSON_withHTTPHeadersAsArrayOfDictionaries() throws {
func test__encodeApolloSchemaDownloadConfiguration__givenAllParameters_shouldReturnJSON_withHTTPHeadersAsArrayOfStructs() throws {
// given
let subject = ApolloSchemaDownloadConfiguration(
using: .introspection(
Expand Down