Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pause/resume websocket without dumping subscriptions #1335

Merged
merged 7 commits into from
Aug 6, 2020
+95 −1
Merged

Add ability to pause/resume websocket without dumping subscriptions #1335

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c57099e
Add pause/resume functionality to web socket transport
designatednerd Jul 30, 2020
bb67716
Add test of pause/resume functionality for websocket transport
designatednerd Jul 30, 2020
d4fee17
make sure subscription is cancelled at the end of the test 🤦‍♀️
designatednerd Jul 30, 2020
4eb1f2a
Don't cancel the subscription until after we've waited for it 🤦‍♀️ 🤦‍♀️
designatednerd Jul 31, 2020
10c3524
wait for the subscription to restart
designatednerd Jul 31, 2020
5f424b4
Remove unnecessary type specification
designatednerd Aug 6, 2020
ab34ab9
clearer naming for subscription
designatednerd Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't cancel the subscription until after we've waited for it 🤦‍♀️ 🤦‍♀️
  • Loading branch information
@designatednerd
designatednerd committed Aug 4, 2020
commit 4eb1f2a6a1026ddd9728dfa2a13a71908bcaf44f
6 changes: 3 additions & 3 deletions Tests/ApolloWebsocketTests/StarWarsSubscriptionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,10 +471,10 @@ class StarWarsSubscriptionTests: XCTestCase {
// Now that we've reconnected, this should go through to the same subscription.
sendReview()

// Cancel subscription so it doesn't keep receiving from other tests.
sub.cancel()

self.wait(for: [subscriptionExpectation], timeout: 10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.wait(for: [subscriptionExpectation], timeout: 10)
wait(for: [subscriptionExpectation], timeout: 10)


// Cancel subscription so it doesn't keep receiving from other tests.
sub.cancel()
}
}

Expand Down